Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: update parser for add where for show table region syntax (#12015) #12124

Merged
merged 2 commits into from
Sep 10, 2019
Merged

parser: update parser for add where for show table region syntax (#12015) #12124

merged 2 commits into from
Sep 10, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Update parser to add where for show table region syntax.

Related parser PR: pingcap/parser#554

@crazycs520
Copy link
Contributor Author

/run-all-tests

jackysp
jackysp reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 10, 2019
bb7133
bb7133 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-integration-ddl-test

@bb7133
Copy link
Member

bb7133 commented Sep 10, 2019

/run-unit-test

1 similar comment
@zimulala
Copy link
Contributor

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Sep 10, 2019

/run-all-tests

@zimulala zimulala merged commit 603f0b9 into pingcap:release-2.1 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
component/parser status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @bb7133 @zimulala @jackysp